nydusify: fix pulling all platforms of source image #1146
Conversation
imeoer
requested review from
jiangliu,
changweige and
hsiangkao
and removed request for
a team
imeoer
force-pushed
the
nydusify-fix-pull
branch
2 times, most recently
from
24a6d1e
to
8e4446c
Compare
We should only handle specific platform for pulling by `platforms.MatchComparer`, otherwise nydusify will pull the layer data of all platforms for an source image. Signed-off-by: Yan Song <[email protected]>
The `--oci` option is not working, we make it reverse before, this patch fix it and keep compatibility with the old option `--docker-v2-format`. Signed-off-by: Yan Song <[email protected]>
imeoer
force-pushed
the
nydusify-fix-pull
branch
from
8e4446c
to
851fc6d
Compare
imeoer
changed the title
imeoer
changed the title
|
@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/56443 |
|
@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/56444 |
|
@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/56445 |
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
```
golangci-lint run
Error: pkg/converter/provider/ported.go:47:64: SA1019: rCtx.ConvertSchema1 is deprecated: use Schema 2 or OCI images. (staticcheck)
if desc.MediaType == images.MediaTypeDockerSchema1Manifest && rCtx.ConvertSchema1 {
^
Error: pkg/converter/provider/ported.go:20:2: SA1019: "github.com/containerd/containerd/remotes/docker/schema1" is deprecated: use images formatted in Docker Image Manifest v2, Schema 2, or OCI Image Spec v1. (staticcheck)
"github.com/containerd/containerd/remotes/docker/schema1"
^
```
Disabled the check, it's unnecessary to check the ported codes.
Signed-off-by: Yan Song <[email protected]>
|
@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/56459 |
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
We need to forcibly enable `--oci` option for allowing to append related annotation for zran image, otherwise an error be thrown: ``` merge nydus layers: invalid label containerd.io/snapshot/nydus-ref=: invalid checksum digest format ``` Signed-off-by: Yan Song <[email protected]>
|
@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/56479 |
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
nydusify: fix pulling all platforms of source image
We should only handle specific platform for pulling by
platforms.MatchComparer, otherwise nydusify will pullthe layer data of all platforms for an source image.
Fix #1142
nydusify: fix
--ocioption for convert subcommandThe
--ocioption is not working, we make it reverse before,this patch fix it and keep compatibility with the old option
--docker-v2-format.nydusify: forcibly enabled
--ocioption when--oci-refbe enabledWe need to forcibly enable
--ocioption for allowing to appendrelated annotation for zran image, otherwise an error be thrown:
Related PR: containerd/nydus-snapshotter#408 goharbor/acceleration-service#115